Design Forums - Graphic Design & Web Design Forums

chrismitchell · Post 1 Posted 02-11-09

I'm having some trouble with a PHP function for a plugin supplied from one of my current companies suppliers, it needs to be able to have a dynamic caption ID.. the code for the call i'm currently using is below:

PHP Code:


			
if($post_image != ""){

        $post_content = '[caption id="" width"280" align="right" caption= "'.$post_image_caption.'"]<img src="'.$post_image.'" alt="'.$post_image_caption.'" width="280">[/caption]'.$post_content;

    }

but for some reason it doesn't load a caption ID (that is dynamically sent by the supplier)..

I can post the whole of the plug in code if anyone is free to have a look and see what I can't see, been looking at this for days and still cant work it out (even after a weekend away from it LOL)

Cheers guys

designium · Post 2 Posted 02-11-09

where is the online plugin and you´ve online example to show us? i´m not expert but i cant figure out with this piece of code what can be wrong..

tbwcf · Post 3 Posted 02-11-09

I know v little about this but at a glance could it be that caption= " is missing a quote? and/or your a missing ' after ]

Edit: ignore that just realised they wrapped around the whole bit caption= "'.$post_image_caption.'"

chrismitchell · Post 4 Posted 02-11-09

here's the rest of the code:

PHP Code:


			
<?php
/*
Plugin Name: DirectNews XML Scheduled Importer
Plugin URI: http://support.directnews.co.uk
Description: A plugin which imports data from a DirectNews XML feed on a scheduled basis. 
Version: 0.2
Author: Adfero Ltd
Author URI: http://www.adfero.co.uk
*/
/* options are deleted in case of plugin deactivation */
require_once(ABSPATH . 'wp-admin/includes/admin.php');
require_once(ABSPATH . 'wp-includes/post.php');
add_action('deactivate_dnxml-sched/dnxmlshed.php', 'dnxml_sched_deactivate');
function dnxml_sched_deactivate() {
    delete_option("dnxml_sched_url");
    delete_option("dnxml_sched_inseconds");
    delete_option("dnxml_sched_recc");
    delete_option("dnxml_sched_triggercount");
}

/* Admin options page display function is called */
add_action('admin_menu', 'dnxml_sched_add_admin_pages');
function dnxml_sched_add_admin_pages() {
    add_options_page('DirectNews Scheduler', 'DirectNews Scheduler', 10, __FILE__, 'dnxml_sched_options_page');
}

/* Options sent by the options form are set here */
/* Schedules are activated and deactivated */
add_action('init', 'dnxml_sched_setoptions');
function dnxml_sched_setoptions() {
    if(!empty($_POST['dnxml_sched_stop'])) {
        $timestamp = wp_next_scheduled('dnxml_sched_hook', array("url" => get_option("dnxml_sched_url")));
        /* This is where the event gets unscheduled */
        wp_unschedule_event($timestamp, "dnxml_sched_hook", array("url" => get_option("dnxml_sched_url")));
    }
    if(!empty($_POST['dnxml_sched_url'])) {
        update_option("dnxml_sched_url",$_POST['dnxml_sched_url']);
    }
    if(!empty($_POST['dnxml_sched_inseconds'])) {
        update_option("dnxml_sched_inseconds",$_POST['dnxml_sched_inseconds']);
        /* This is where the actual recurring event is scheduled */
        if (!wp_next_scheduled('dnxml_sched_hook', array("url" => get_option("dnxml_sched_url")))) {
            wp_schedule_event(time()+$_POST['dnxml_sched_inseconds'], "dnxml_sched_recc", "dnxml_sched_hook", array("url" => get_option("dnxml_sched_url")));
            dnxml_sched_trigger_schedule(get_option("dnxml_sched_url"));
        }
    }
}

/* a reccurence has to be added to the cron_schedules array */
add_filter('cron_schedules', 'dnxml_sched_more_reccurences');
function dnxml_sched_more_reccurences($recc) {
    $recc['dnxml_sched_recc'] = array('interval' => get_option("dnxml_sched_inseconds"), 'display' => 'DirectNews XML Import Schedule');
    return $recc;
}

/* This is the scheduling hook for our plugin that is triggered by cron */
add_action('dnxml_sched_hook','dnxml_sched_trigger_schedule');
function dnxml_sched_trigger_schedule($url) {
    //extract($url);
    dnxml_sched_load_articles($url);
    update_option("dnxml_sched_triggercount",get_option("dnxml_sched_triggercount")+1);
}

/* The options page display */
function dnxml_sched_options_page() {
    ?>
    <div class=wrap>
        <h2>DirectNews XML Scheduled Importer</h2>
        <p></p>
        <div style="padding: 10px; border: 1px solid #cccccc;">
        <?php
        if (wp_next_scheduled('dnxml_sched_hook', array("url" => get_option("dnxml_sched_url")))) {
            ?>
            <p><b>DirectNews XML Importer is scheduled!</b></p>
            <pre><?php
            $crons = _get_cron_array();
             foreach ( $crons as $timestamp => $cron ) {
                 if ( isset( $cron['dnxml_sched_hook'] ) ) {
                    echo 'Time now:'." \t\t\t".date(get_option('date_format'))." ".date("H:i:s")."<br />";
                    echo 'Schedule will be triggered:'." \t".date(get_option('date_format'),$timestamp)." ".date("H:i:s",$timestamp)."<br />";
                 }
             } 
            ?><a href="<?php bloginfo('wpurl') ?>/wp-admin/options-general.php?page=dnxmlshed.php">refresh</a><br />
            </pre>
            <form method="post" action="<?php echo $_SERVER["REQUEST_URI"]; ?>">
            <input type="submit" name="dnxml_sched_stop" id="dnxml_sched_stop" value="To turn off importer schedules" />
            </form>
            <?php
            if(get_option("dnxml_sched_triggercount") > 0) {
            ?>
            <p>DirectNews XML Schedule was triggered
            <?php echo get_option("dnxml_sched_triggercount");?> times.</p>
            <?php
            }
        } else {
            ?>
            <p>DirectNews XML Importer is NOT scheduled!</p>
      <?php //dnxml_sched_load_articles(get_option("dnxml_sched_url")); ?>
            <?php
        }
 
        ?>
        </div>
        <?php
        if (!wp_next_scheduled('dnxml_sched_hook', array("url" => get_option("dnxml_sched_url")))) {
        ?>
        <br />
        <form style="padding: 10px; border: 1px solid #cccccc;" method="post" action="<?php echo $_SERVER["REQUEST_URI"]; ?>">
        <p>Set up a new import schedule</p><br />
        DirectNews XML URL <input type="text" name="dnxml_sched_url" value="<?php echo get_option("dnxml_sched_url"); ?>" /><br />
        Seconds from now until this schedule should be triggered:<br />
        <input type="text" name="dnxml_sched_inseconds" value="<?php echo get_option("dnxml_sched_inseconds"); ?>" />seconds<br />
        <input type="submit" name="dnxml_sched_submit" id="dnxml_sched_submit" value="Set Import Schedule" />
        </form>
        <?php
        }
        ?>
    </div>
    <?php
}

function dnxml_sched_load_articles($url) {
    global $wpdb, $post;
 
    $articles = array ();
    set_magic_quotes_runtime(0);
 
    $doc = new DOMDocument();
 
    //Note: load using FOpen
    //Please comment the following code if cURL is used.
    //$doc->load($url);
 
    //Note: If fopen is disabled use curl
    // Please uncomment the code below to use cURL .
        
        $feedData = getFile($url,3600);
        $doc->loadXML($feedData);
    
 
    $xpath = new DOMXPath($doc);
    // Selecting nodes matching node "Article" using xpath_eval command and passing it the xpath context
    $nodes = $xpath->evaluate("//Article", $doc);
    // For each nodes in the collection we loop through each node and retrive and save the data.
    for ($i = 0; $i < $nodes->length; $i++) {
        $date = $nodes->item($i)->getElementsByTagName('Date')->item(0)->nodeValue;
        $time = $nodes->item($i)->getAttribute('Created');
        $nodeTmp = $nodes->item($i);
        $post_title = $nodes->item($i)->getElementsByTagName('Heading')->item(0)->nodeValue;
        $post_content = $nodes->item($i)->getElementsByTagName('Contents')->item(0)->nodeValue;
    $post_image = $xpath->evaluate('Picture/Large/URL', $nodes->item($i))->item(0)->nodeValue;
    $post_image_caption = $xpath->evaluate('Picture/PhotoTag', $nodes->item($i))->item(0)->nodeValue;
        $post_date;
        $post_date_gmt;
        $post_author = 1;
        $post_status = 'publish';
        $guid = $nodes->item($i)->getAttribute('ID');
        $categories = array();;
 
        $Catquery = 'Categories/Category';
        $CatColl = $xpath->evaluate($Catquery,$nodeTmp);
        $cat_index = 0;
        foreach ($CatColl as $category){
            $trans_tbl = get_html_translation_table(HTML_ENTITIES);
            $trans_tbl = array_flip($trans_tbl);
            $categories[$cat_index] = $wpdb->escape($category->nodeValue);
            $cat_index++;
        }
 
    //add picture if available
    if($post_image != ""){
        $post_content = '[caption id="" width"280" align="right" caption= "'.$post_image_caption.'"]<img src="'.$post_image.'" alt="'.$post_image_caption.'" width="280">[/caption]'.$post_content;
    }
        //Do some formatting
 
        list($day, $month, $year) = split('[/]',$date);
        $post_date_gmt = $year.'-'.$month.'-'.$day.' '.$time;
        $post_date_gmt = strtotime($post_date_gmt);
        $post_date_gmt = gmdate('Y-m-d H:i:s', $post_date_gmt);
        $post_date = get_date_from_gmt( $post_date_gmt );
        $post_content = preg_replace('|<(/?[A-Z]+)|e', "'<' . strtolower('$1')", $post_content);
        $post_content = str_replace('<br>', '<br />', $post_content);
        $post_content = str_replace('<hr>', '<hr />', $post_content);
        //$post_content = str_replace("'", "''", $post_content);
        //$post_title = str_replace("'", "''", $post_title);
 
        //Save the article to the articles array
        $articles[$i] = compact('post_author', 'post_date', 'post_date_gmt', 'post_content', 'post_title', 'post_status', 'categories');
    }
    //import into wordpress
    $cat_index = 0;
    foreach ($articles as $article) {
        extract($article);
        if ($post_id = post_exists($post_title, $post_content, $post_date)) {
      //TODO: update story
        } else {
      //insert new story
            $post_id = wp_insert_post($article);
            if ( is_wp_error( $post_id ) )
                return $post_id;
            if (!$post_id) {
                return;
            }
            
            if (count($categories) > 0)
            {
                print_r($categories);
                echo "t<hr/>";

                //wp_create_categories($categories1, $post_id);
                $catIDs1 = array();
                $i=0;
                foreach($categories as $cat1){
                    print_r($cat1);
                    $catIDs1[$i] = wp_create_category($cat1,5);
                    $i++;
                }
                print_r($catIDs1);
                echo "b<hr/>";
                echo "<hr/>";
                wp_set_post_categories($post_id,$catIDs1);
            }
        }
        $cat_index++;
    }
}
function getFile($url,$timeout) {
 
    # use CURL library to fetch remote file
    $ch = curl_init();
    $url = $url;
 
    curl_setopt ($ch, CURLOPT_URL, $url);
    curl_setopt ($ch, CURLOPT_RETURNTRANSFER, 1);
    curl_setopt ($ch, CURLOPT_CONNECTTIMEOUT, $timeout);
    $file_contents = curl_exec($ch);
    if ( curl_getinfo($ch,CURLINFO_HTTP_CODE) !== 200 ) {
      throw new Exception('Return Status: '.curl_getinfo($ch,CURLINFO_HTTP_CODE).', please try again after a while, could not load URL :'.$url);
      return false;
    } else {
      return $file_contents;
    }
}
?>

Thanks for all your help guys

would be good for me to get this working before I leave this place

Jazajay · 02:59 PM

Sorry fella didn't go through all that code but kinda going on a guess here ~

Quote:

...but for some reason it doesn't load a caption ID...

So this ~
if($post_image != ""){
$post_content = '[caption id=""...

Should be this maybe~

if($post_image != ""){
$post_content = '[caption id="'.$_POST["posted_clients_caption_id_goes_in_here_possib ly"]...

As it looks like you are not assigning the caption id sent to the caption id attribute.
Is that it before I look at the code?

Key ~
Red ~ PHP

Jazajay · Post 6 Posted 02-11-09

Also looking at it from a security point of view, is the post_image tested to make sure it is an image?
Also you should limit the file path to a certain directory, otherwise you've just opened up your server for a hacker to retrieve pretty much any file including DB passwords and more they want. If there isn't any more security let me know and I'll wack you some up fella to make sure your protected.

Jaz

chrismitchell · Post 7 Posted 02-11-09

thanks for that Jaz

I will test that out tomorrow

Jazajay · Post 8 Posted 02-11-09

Okay no worries fella, even if that fixes it which it should do, double check about the security though yeah otherwise it may cause you some head aches later on. If you want secure code to sanitize the data let me know as I wrote some extremely intensive ones a while back for a file upload script and I'll dig them out for you if you want.

Darren · Post 9 Posted 06-11-09

PHP Code:


			
 //add picture if available
    if($post_image != ""){
        $post_content = '[caption id="'.$guid.'" width"280" align="right" caption= "'.$post_image_caption.'"]<img src="'.$post_image.'" alt="'.$post_image_caption.'" width="280">[/caption]'.$post_content;
    }

That should work, try it.

Quote:

Originally Posted by Jazajay

Sorry fella didn't go through all that code but kinda going on a guess here ~

So this ~
if($post_image != ""){
$post_content = '[caption id=""...

Should be this maybe~

if($post_image != ""){
$post_content = '[caption id="'.$_POST["posted_clients_caption_id_goes_in_here_possib ly"]...

As it looks like you are not assigning the caption id sent to the caption id attribute.
Is that it before I look at the code?

Key ~
Red ~ PHP

This wont, its loading the data via XML. Its not being posted.

chrismitchell · Post 10 Posted 06-11-09

I will forward this on to my old company LOL i'm sure that they will try to make it work

thanks again fellas

Jazajay · Post 11 Posted 07-11-09

That is so semantics what I said was

Quote:

As it looks like you are not assigning the caption id

Which is the solution, lol, loving it though.

Semantically though I suppose my answer was wrong but I didn't say it was the correct code hence why I gave him a made up post name, I just gave him the reason why it wasn't working, which as you point out is correct.

Quote:

Should be this maybe

As I didn't have time to go through the code at the time ~

Quote:

Sorry fella didn't go through all that code but kinda going on a guess here

Lol, loving it.

Jaz

Jazajay · Post 12 Posted 07-11-09

Can some 1 merge those posts, I think I explain myself slightly better in the second 1 though and delete this. I pressed post but I couldn't see my response even after a page refresh, so I rewrote it.

Cheers Jaz

chrismitchell · Post 13 Posted 07-11-09

done for you Jaz

Jazajay · Post 14 Posted 07-11-09

Cheers Chris

Darren · 12:18 PM

Quote:

Originally Posted by Jazajay

That is so semantics what I said was

Which is the solution, lol, loving it though.

Semantically though I suppose my answer was wrong but I didn't say it was the correct code hence why I gave him a made up post name, I just gave him the reason why it wasn't working, which as you point out is correct.

As I didn't have time to go through the code at the time ~

Lol, loving it.

Jaz

I am not sure where this came from at all, is there something wrong?. The first thing to note here is that at no point did I say you were wrong about anything. I said the code would not work.

I didn't have much time myself and just quickly glanced over the code and then seen your solution. My post simply offered the correct solution, assuming of course that the problem is indeed the issue of a missing ID from the string shown in the first post, and also mentioned that your code would not work and why.

My post can maybe be seen as quite abrupt(?) but that is because I didnt have much time, and most of the posts I type come across as that anyway. But I can assure you that I didnt mean anything other than offering a solution and why yours would not work to stop the OP from wasting time on it.

However, I have some more time now (bored stuck in London till tonight - nothing much happening with work - and just found that these forums work on the proxy

) so can maybe explain a little more on the way its working.....

As mentioned, this code has nothing to do with POST'd data and instead does something entirely different, which is read an xml feed and extract the node values into variables (mostly prefixed $post_)

PHP Code:


			
Description: A plugin which imports data from a DirectNews XML feed on a scheduled basis.

I assume the prefix $post_ on the variable names stand for "news post".

I noticed that the ID of the post is already extracted from the XML here;

PHP Code:


			
$guid = $nodes->item($i)->getAttribute('ID');

which assumes that the XML looks like this for each post(or article);

Code:

<Article ID="24">
... Child Notes Here ...
</Article>

so it was simply just a case of adding the existing $guid variable containing the post ID to the string.

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

designium designer 93 Posts portugal	where is the online plugin and you´ve online example to show us? i´m not expert but i cant figure out with this piece of code what can be wrong.. Designi1 140 words at the time - what i´m doing here?!
	Post 2 Posted 02-11-09

tbwcf Designer/Developer 1,122 Posts	I know v little about this but at a glance could it be that caption= " is missing a quote? and/or your a missing ' after ] Edit: ignore that just realised they wrapped around the whole bit caption= "'.$post_image_caption.'" The boy who cried fox. Tweeting it up
	Post 3 Posted 02-11-09

chrismitchell Doom! / Team DF 5,379 Posts Milton Keynes	thanks for that Jaz I will test that out tomorrow The Widdler's Wee Online Farm \| Widdler's Wee Creative \| Follow us on Twitter \| Newswipe Now Live! Come join the Rant! Just remember.. no matter how happy you think you are, you're never as happy as a Pineapple Chunk... They're well happy! Don't forget to donate blood!
	Post 7 Posted 02-11-09

chrismitchell Doom! / Team DF 5,379 Posts Milton Keynes	I will forward this on to my old company LOL i'm sure that they will try to make it work thanks again fellas The Widdler's Wee Online Farm \| Widdler's Wee Creative \| Follow us on Twitter \| Newswipe Now Live! Come join the Rant! Just remember.. no matter how happy you think you are, you're never as happy as a Pineapple Chunk... They're well happy! Don't forget to donate blood!
	Post 10 Posted 06-11-09

chrismitchell Doom! / Team DF 5,379 Posts Milton Keynes	done for you Jaz The Widdler's Wee Online Farm \| Widdler's Wee Creative \| Follow us on Twitter \| Newswipe Now Live! Come join the Rant! Just remember.. no matter how happy you think you are, you're never as happy as a Pineapple Chunk... They're well happy! Don't forget to donate blood!
	Post 13 Posted 07-11-09

Jazajay Dev.Project manager 1,333 Posts Leicester, UK	Cheers Chris Do your bit keep children safe and report illegal content to the IWF. ADHD or a reaction to food additives? The Hyperactive Children's Support Group Ever wondered how to create a contact form for your site? Then follow this easy tutorial Does your site meet the legal requirements of the DDA? Not sure then find out if it does
	Post 14 Posted 07-11-09

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)

Design Forums - Graphic Design & Web Design Forums

PHP problems